Skip to content

chore: extract skipTest into its own harness module #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legendecas merged 2 commits into from
Apr 27, 2026
+17 −4
Merged

chore: extract skipTest into its own harness module #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562172b
chore: extract skipTest into its own harness module
kraenhansen Apr 25, 2026
cd7f6e4
Merge branch 'main' into kh/extract-skip-test
legendecas Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions implementors/node/features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,3 @@ globalThis.experimentalFeatures = {
setPrototype: true,
postFinalizer: true,
};

globalThis.skipTest = () => {
process.exit(0);
};
3 changes: 3 additions & 0 deletions implementors/node/skip-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
globalThis.skipTest = () => {
process.exit(0);
};
8 changes: 8 additions & 0 deletions implementors/node/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ const MUST_CALL_MODULE_PATH = path.join(
"node",
"must-call.js"
);
const SKIP_TEST_MODULE_PATH = path.join(
ROOT_PATH,
"implementors",
"node",
"skip-test.js"
);
const NAPI_VERSION_MODULE_PATH = path.join(
ROOT_PATH,
"implementors",
Expand Down Expand Up @@ -87,6 +93,8 @@ export function runFileInSubprocess(
"--import",
"file://" + MUST_CALL_MODULE_PATH,
"--import",
"file://" + SKIP_TEST_MODULE_PATH,
"--import",
"file://" + NAPI_VERSION_MODULE_PATH,
filePath,
],
Expand Down
6 changes: 6 additions & 0 deletions tests/harness/skip-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
'use strict';

// skipTest is a function
if (typeof skipTest !== 'function') {
throw new Error('Expected a global skipTest function');
}
Loading