Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 12, 2025

Instead of trying to parse git tag output (which is not stable), we could simply download the keyring from nodejs/release-keys and rely on the exit code. It should no longer provide false negatives.

@aduh95 aduh95 requested a review from targos October 12, 2025 19:02
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.73%. Comparing base (9b642b0) to head (a176326).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files          39       39           
  Lines        4664     4664           
=======================================
  Hits         3719     3719           
  Misses        945      945           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@aduh95 aduh95 merged commit 48a418b into nodejs:main Nov 8, 2025
13 checks passed
@aduh95 aduh95 deleted the verify-official-keyring branch November 8, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants