Skip to content

Conversation

@ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Apr 27, 2019

No description provided.

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #340 into master will increase coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #340     +/-   ##
========================================
+ Coverage    75.8%   76.6%   +0.8%     
========================================
  Files          21      21             
  Lines        1368    1368             
========================================
+ Hits         1037    1048     +11     
+ Misses        331     320     -11
Impacted Files Coverage Δ
lib/cli.js 87.27% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3229743...d2b1ffb. Read the comment docs.


it('should print an error message', () => {
cli.error(new Error('Error!'));
assert.strictEqual(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert.ok()

@priyank-p priyank-p requested a review from joyeecheung June 23, 2019 20:43
@joyeecheung joyeecheung merged commit f3f59da into nodejs:master Jun 26, 2019
@ZYSzys ZYSzys deleted the cli-test branch July 1, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants