Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Nov 2, 2020

Use a gitattributes file to force text files to be checked out with LF
line endings. This resolves issues on Windows with tests that compare
values with the contents of files on disk.

Use a gitattributes file to force text files to be checked out with LF
line endings. This resolves issues on Windows with tests that compare
values with the contents of files on disk.
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files          35       35           
  Lines        1742     1742           
=======================================
  Hits         1437     1437           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca0fb4...0b5d760. Read the comment docs.

@targos
Copy link
Member Author

targos commented Nov 2, 2020

macOS seems flaky :

  1 failing

  1) auth
       asks for auth data if no ncurc is found:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/node-core-utils/node-core-utils/test/unit/auth.test.js)
  

@targos targos merged commit 74a6b69 into nodejs:master Nov 3, 2020
@targos targos deleted the fix-windows-ci branch November 3, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants