Conversation
002-es6-modules.md
Outdated
| * **[HostResolveImportedModule]** | ||
| - A hook for when an import is exactly performed. | ||
| * **[HostResolveImportedModule](https://tc39.github.io/ecma262/#sec-hostresolveimportedmodule)** | ||
| - A hook for when an import is exactly performed. This returns a `ModuleRecord`. Used as a means to grab modules from node's loader/cache. |
|
lgtm sans inline nits, I also don't like the heavy inconsistency in line lengths (personally I'd prefer paragraphs on a single line but it's consistency I care about more) but not enough to hold this up, just a note for future process improvement perhaps. |
|
@rvagg https://tc39.github.io/ecma262/ doesn't always highlight names, was trying to match them, though saw no direct style guide, will amend though |
|
@rvagg fixed, though some lines still exceed 80, (code and href) |
|
You can argue line-length with @trevnorris and @bnoordhuis, they are the ones who use XGA CRT monitors which have limitations, I'm easy as long as it looks consistent. lgtm, happy to see this landed after the usual delay, would appreciate additional review of course.
|
002-es6-modules.md
Outdated
| 7. Let `value` be ! `O`.`[[Get]]`(`P`,` O`) | ||
| 8. Return `value` | ||
|
|
||
| #### 3.2.2. `DelegatedModuleNamespaceObjectCreate(module,O)` |
There was a problem hiding this comment.
Should there be a space after the comma?
|
It's OK @trevnorris, you don't need to explain
|
|
@trevnorris fixed |
|
LGTM |
Change the document's formatting, numbering and style to match the TC39 spec algorithm explanation. Clarify [[Environment]] and [[Realm]] PR-URL: #23 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
Thanks much! Squashed and landed in 2272a81. |
3 participants
Uh oh!
There was an error while loading. Please reload this page.