module: implement Symbol.dispose in ModuleHooks

This change implements the `Symbol.dispose` key in the
`ModuleHooks` class as an alias for deregister. This makes
`registerHooks` work with the `using` keyword.

Fixes: #63846
Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
PR-URL: #63928
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Jacob Smith <jacob@frende.me>

Author: remcohaszing

doc/api/module.md

@@ -243,6 +243,7 @@ changes:
   * `deregister()` {Function} Remove the registered hooks so that they are no
     longer called. Hooks are otherwise retained for the lifetime of the running
     process.
+  * `[Symbol.dispose]` {Function} The same as `deregister`.
 
 Register [hooks][] that customize Node.js module resolution and loading behavior.
 See [Customization hooks][]. The returned object can be used to

lib/internal/modules/customization_hooks.js

@@ -9,6 +9,7 @@ const {
   StringPrototypeSlice,
   StringPrototypeStartsWith,
   Symbol,
+  SymbolDispose,
 } = primordials;
 const {
   isAnyArrayBuffer,
@@ -83,10 +84,7 @@ class ModuleHooks {
 
     ObjectFreeze(this);
   }
-  // TODO(joyeecheung): we may want methods that allow disabling/enabling temporarily
-  // which just sets the item in the array to undefined temporarily.
-  // TODO(joyeecheung): this can be the [Symbol.dispose] implementation to pair with
-  // `using` when the explicit resource management proposal is shipped by V8.
+
   /**
    * Deregister the hook instance.
    */
@@ -103,6 +101,8 @@ class ModuleHooks {
   }
 };
 
+ModuleHooks.prototype[SymbolDispose] = ModuleHooks.prototype.deregister;
+
 /**
  * TODO(joyeecheung): taken an optional description?
  * @param {{ resolve?: ResolveHook, load?: LoadHook }} hooks User-provided hooks

test/module-hooks/test-module-hooks-dispose.js

@@ -0,0 +1,26 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const { registerHooks } = require('module');
+
+// Test that using syntax works.
+{
+  // eslint-disable-next-line no-unused-vars
+  using hook = registerHooks({
+    load: common.mustCall((url, context, nextLoad) => {
+      const result = nextLoad(url, context);
+      assert.strictEqual(result.source, '');
+      return {
+        source: 'export const hello = "world"',
+      };
+    }),
+  });
+
+  const mod = require('../fixtures/empty.js');
+  assert.strictEqual(mod.hello, 'world');
+}
+
+delete require.cache[require.resolve('../fixtures/empty.js')];
+const mod = require('../fixtures/empty.js');
+assert.deepStrictEqual(mod, {});