sea: avoid dangling CLI option pointers

Reserve exec argv storage before inserting configured and CLI-expanded
arguments so vector reallocation cannot invalidate pointers in argv.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64755
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

Author: Archkon

src/node_sea.cc

@@ -308,10 +308,11 @@ std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv) {
                      cli_extension_args.size() + 2);
     new_argv.emplace_back(argv[0]);
 
+    exec_argv_storage.reserve(sea_resource.exec_argv.size() +
+                              cli_extension_args.size());
+
     // Insert exec argv from SEA config
     if (!sea_resource.exec_argv.empty()) {
-      exec_argv_storage.reserve(sea_resource.exec_argv.size() +
-                                cli_extension_args.size());
       for (const auto& arg : sea_resource.exec_argv) {
         exec_argv_storage.emplace_back(arg);
         new_argv.emplace_back(exec_argv_storage.back().data());

test/fixtures/sea/exec-argv-extension-cli/sea-config.json

@@ -2,6 +2,5 @@
   "main": "sea.js",
   "output": "sea-prep.blob",
   "disableExperimentalSEAWarning": true,
-  "execArgv": ["--no-warnings"],
   "execArgvExtension": "cli"
 }

test/fixtures/sea/exec-argv-extension-cli/sea.js

@@ -3,7 +3,7 @@ const assert = require('assert');
 console.log('process.argv:', JSON.stringify(process.argv));
 console.log('process.execArgv:', JSON.stringify(process.execArgv));
 
-// Should have execArgv from SEA config + CLI --node-options
+// Should have all options from CLI --node-options
 assert.deepStrictEqual(process.execArgv, ['--no-warnings', '--max-old-space-size=1024']);
 
 assert.deepStrictEqual(process.argv.slice(2), [

test/sea/test-single-executable-application-exec-argv-extension-cli.js

@@ -23,7 +23,11 @@ const outputFile = generateSEA(fixtures.path('sea', 'exec-argv-extension-cli'));
 // Test that --node-options works with execArgvExtension: "cli"
 spawnSyncAndAssert(
   outputFile,
-  ['--node-options=--max-old-space-size=1024', 'user-arg1', 'user-arg2'],
+  [
+    '--node-options=--no-warnings --max-old-space-size=1024',
+    'user-arg1',
+    'user-arg2',
+  ],
   {
     env: {
       ...process.env,