Skip to content

Commit 3eea70d

Browse files
guhyunwooaduh95
authored andcommitted
test: fix Linux debug skip in SEA test guard
process.config.variables.is_debug is only populated by the GN build flow (tools/generate_config_gypi.py), so on the gyp builds used by CI the guard never fired and SEA tests ran on Linux debug builds against the original intent. Switch to process.config.target_defaults.default_configuration === 'Debug', matching the pattern used in test/common/index.js. Fixes: #63749 Refs: #61483 Signed-off-by: Hyunwoo Gu <realization0327@gmail.com> PR-URL: #63751 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 31b5f6c commit 3eea70d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

test/common/sea.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ function skipIfSingleExecutableIsNotSupported() {
2020
if (!['darwin', 'win32', 'linux'].includes(process.platform))
2121
common.skip(`Unsupported platform ${process.platform}.`);
2222

23-
if (process.platform === 'linux' && process.config.variables.is_debug === 1)
23+
if (process.platform === 'linux' && common.isDebug)
2424
common.skip('Running the resultant binary fails with `Couldn\'t read target executable"`.');
2525

2626
if (process.config.variables.node_shared)

0 commit comments

Comments
 (0)