fs: key glob matcher cache by platform

Glob matchers capture the path platform when they are created. Include
the platform in the cache key so path.posix and path.win32 do not share
incompatible matchers for the same pattern.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64571
Fixes: #64570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Author: Archkon

lib/internal/fs/glob.js

@@ -936,15 +936,16 @@ function matchGlobPattern(path, pattern, windows = isWindows) {
   validateString(path, 'path');
   validateString(pattern, 'pattern');
 
+  const cacheKey = `${windows ? 'win32' : 'posix'}:${pattern}`;
   let matcher;
-  if (patternFnCache.has(pattern)) {
-    matcher = patternFnCache.get(pattern);
+  if (patternFnCache.has(cacheKey)) {
+    matcher = patternFnCache.get(cacheKey);
   } else {
     matcher = createMatcher(pattern, {
       kEmptyObject,
       platform: windows ? 'win32' : 'posix',
     });
-    patternFnCache.set(pattern, matcher);
+    patternFnCache.set(cacheKey, matcher);
 
     if (patternFnCache.size >= kGlobPatternCacheLimit) {
       patternFnCache.delete(patternFnCache.keys().next().value);

test/parallel/test-path-glob.js

@@ -31,6 +31,9 @@ const globs = {
   ],
 };
 
+// Matchers for the same pattern must not be shared across path platforms.
+assert.strictEqual(path.posix.matchesGlob('platform-cache/file', 'platform-cache/**'), true);
+assert.strictEqual(path.win32.matchesGlob('platform-cache\\file', 'platform-cache/**'), true);
 
 for (const [platform, platformGlobs] of Object.entries(globs)) {
   for (const [pathStr, glob, expected] of platformGlobs) {