Skip to content

Commit c73c8e6

Browse files
committed
test: skip test-temporal-with-zoneinfo on system-icu builds
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #62754 Refs: #62676 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 16860e6 commit c73c8e6

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

configure.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2392,6 +2392,7 @@ def icu_download(path):
23922392

23932393
# always set icu_small, node.gyp depends on it being defined.
23942394
o['variables']['icu_small'] = b(False)
2395+
o['variables']['icu_system'] = b(False)
23952396

23962397
# prevent data override
23972398
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']
@@ -2428,6 +2429,7 @@ def icu_download(path):
24282429
o['variables']['v8_enable_i18n_support'] = 1
24292430
elif with_intl == 'system-icu':
24302431
# ICU from pkg-config.
2432+
o['variables']['icu_system'] = b(True)
24312433
o['variables']['v8_enable_i18n_support'] = 1
24322434
pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
24332435
if not pkgicu[0]:

test/parallel/test-temporal-with-zoneinfo.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ if (!process.config.variables.v8_enable_temporal_support) {
1212
if (!common.hasFullICU) {
1313
common.skip('Time zone support unavailable when not built with full ICU');
1414
}
15+
// TODO(aduh95): fix zoneinfo support with system-icu.
16+
if (process.config.variables.icu_system) {
17+
common.skip('Time zone support unavailable on --with-intl=system-icu builds');
18+
}
1519

1620
// Use globalThis.Temporal to workaround linter complaints.
1721
assert.strictEqual(typeof globalThis.Temporal, 'object');

0 commit comments

Comments
 (0)