symlink out/Release/lib.target → out/Release/lib needs to be created manually before “make install”

[dilyanpalauzov]

On my Linux from Scratch system, building node 12.13.0 with ./configure --gdb --enable-lto --ninja --shared --openssl-use-def-ca-store and python 3 creates the file out/Release/lib/libnode.so.72 but “make install” looks for the file out/Release/lib.target/libnode.so.72. So I have to create symlink out/Release/lib.target → out/Release/lib.

Moreover, ./configure --ninja suggests, that after ./configure has finished, one can call ninja, but this does not work. I know the Makefile calls ninja, but running direct ninja shall also work.

[dilyanpalauzov]

For the record, after ./configure is done, I do not call make (as it ignores apparently -j1 when calling ninja), but do cd out/Releases && ninja -j1.

[sam-github]

./configure --ninja suggests, that after ./configure has finished, one can call ninja, but this does not work. I know the Makefile calls ninja, but running direct ninja shall also work.

I do ./configure --ninja; ninja -C out/Release all the time, it works fine.

I never install, but I just tried ./configure --ninja; ninja -C out/Release; make install DESTDIR=/tmp/whatever works. I don't have the hours it would take to change config options and rebuild to confirm your issue.

ninja is used by some of us because its builds work significantly better, but it doesn't surprise me that it doesn't work as well as the way builds are done in CI for some uses.

Just to set expecations, this might tweak someone's interest, but since using ninja is entirely optional, you might need to PR a fix if you want it.

[dilyanpalauzov]

Yes. I expect that ./configure --ninja && ninja does work, without -C out/Release as this is how the build projects of nearly evetything work.

[sam-github]

I'm fairly confident a PR to make that so would be accepted. It would have to decide (how?) if a debug or release build is intended and recurse into the correct subdir.

[martinvahi]

Similar problem with 2021_12 LTS (I assume that LTS stands for "long-term release").

https://nodejs.org/dist/v16.13.1/node-v16.13.1-linux-x64.tar.xz

Some script seems to look for

out/Release/libnode.so.93
# but the libnode.so.93 is actually at 
out/Release/lib/libnode.so.93

Partial console citation:

mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ ./configure --prefix=/home/mmmv/applications/NodeJS/2021_12_16_v_16_13_1 --with-intl full-icu --gdb --shared  --v8-enable-object-print --ninja 

...

mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ time nice -n 20 make

...

mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ make install
ninja -C out/Release 
ninja: Entering directory `out/Release'
ninja: no work to do.
if [ ! -r node ] || [ ! -L node ]; then ln -fs out/Release/node node; fi
/usr/bin/python3.7 tools/install.py install '' '/home/mmmv/applications/NodeJS/2021_12_16_v_16_13_1'
installing /home/mmmv/applications/NodeJS/2021_12_16_v_16_13_1/lib/libnode.so.93
Traceback (most recent call last):
  File "tools/install.py", line 262, in <module>
    run(sys.argv[:])
  File "tools/install.py", line 253, in run
    files(install)
  File "tools/install.py", line 148, in files
    action([output_prefix + output_file], 'lib/' + output_file)
  File "tools/install.py", line 76, in install
    try_copy(path, dst)
  File "tools/install.py", line 66, in try_copy
    return shutil.copy2(source_path, target_path)
  File "/usr/lib/python3.7/shutil.py", line 263, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/lib/python3.7/shutil.py", line 120, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: 'out/Release/libnode.so.93'
make: *** [Makefile:164: install] Error 1
mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ ls
AUTHORS             GOVERNANCE.md  android-configure  config.status  icu_config.gypi  out            vcbuild.bat
BSDmakefile         LICENSE        benchmark          configure      lib              src
BUILDING.md         Makefile       codecov.yml        configure.py   node             test
CHANGELOG.md        README.md      common.gypi        deps           node.gyp         tools
CODE_OF_CONDUCT.md  SECURITY.md    config.gypi        doc            node.gypi        tsconfig.json
CONTRIBUTING.md     __pycache__    config.mk          glossary.md    onboarding.md    typings
mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ ls ./out/
Debug  Release  tools
mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ ls ./out/Release/
build.ninja                       gen                      lib          node_mksnapshot     torque
bytecode_builtins_list_generator  gen-regexp-special-case  mkcodecache  obj
cctest                            genccode                 mksnapshot   openssl-cli
embedtest                         icupkg                   node         overlapped-checker
mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ ls ./out/Release/lib/
libnode.so.93  libnode.so.93.TOC  libtest_crypto_engine.so  libtest_crypto_engine.so.TOC
mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$ uname -a
Linux hoidla03 4.19.0-18-amd64 #1 SMP Debian 4.19.208-1 (2021-09-29) x86_64 GNU/Linux
mmmv@hoidla03:~/applications/NodeJS/kompil/node-v16.13.1$