HTTP2 Server Upgrade listener undocumented

[najibghadri]

• All versions that have HTTP2 and HTTPS* implemented
• Documentation problem

The code below shows what is up. I wonder what could be the reason that it works even-tough it is undocumented even in the typescript definitions that come with npm.
I would say this is due to C++ inheritance from HTTPServer to HTTPSServer and HTTP2Server, but no idea, someone could look into it to make sure.

const server = http2.createServer({
  allowHTTP1: true
});

server.on('upgrade', (request, socket, head) => {
  // This does work, but no documentation anywhere (internet, TS definitions, ancestor classes neither)
  // (One could add as ws upgrade handler here)
});

Edit: apparently it is undocumented in the node HTTPS Server as well.

[juanarbol]

Could you add a code snippet for make upgrade event emitted?

[najibghadri]

Could you add a code snippet for make upgrade event emitted?

It's right there :D If you mean the client side, that's a simple ws (or wss) connection with handshake..

[juanarbol]

Hey @jasnell, you may can answer this docs questions, I've seen the upgrade event documented here: https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_event_upgrade but no on http2 and https docs