[Bug] Nodejs fails to build as DLL

[gprosch]

• Version: 14.15.2
• Platform: Microsoft Windows NT 10.0.19042.0 x64
• Subsystem: Build
• Build: Visual Studio 2019 v16.8.1

What steps will reproduce the bug?

• Running: vcbuild.bat debug vs2019 dll x86

How often does it reproduce? Is there a required condition?

Occurs every time.

What is the expected behavior?

Build finishes successfully and produces a dll.

What do you see instead?

Creating library out\Debug\libnode.lib and object out\Debug\libnode.exp
v8_libbase.lib(platform-win32.obj) : error LNK2019: unresolved external symbol __imp__timeGetTime@0 referenced in function "public: void __thiscall v8::base::Win32Time::SetToCurrentTime(void)" (?SetToCurrentTime@Win32Time@base@v8@@QAEXXZ) [F:\Dev\Subversion\ProductToolsInternal\nodejs\node-14.15.2\libnode.vcxproj]
v8_libbase.lib(time.obj) : error LNK2001: unresolved external symbol __imp__timeGetTime@0 [F:\Dev\Subversion\ProductToolsInternal\nodejs\node-14.15.2\libnode.vcxproj]
out\Debug\libnode.dll : fatal error LNK1120: 1 unresolved externals [F:\Dev\Subversion\ProductToolsInternal\nodejs\node-14.15.2\libnode.vcxproj]

Additional information

Building "Release" produces the same result.

I've tried other versions (14.15.1, 15.4.0), I've tried static, dll, exe builds. I get different issues in some cases (e.g. error C2027: use of undefined type 'v8::internal::Map') but I can't get anything to build cleanly.

I believe I have all the right tools and versions. I even ran the Boxstarter configuration.

[Obaid-Rehman]

I have the same exact issue with Node v.14.15.1 on Windows 10 x64 build. Ran .\vcbuild release vs2019 dll x64 projgen openssl-no-asm and received the same problem.

[Trott]

@nodejs/build @nodejs/platform-windows

[MylesBorins]

@gprosch is there any version of 14 that can build?

[gprosch]

MylesBorins, I tried 14.15.1 and 14.15.2. I was unable to build either.

[Reveares]

This seems to be a long standing problem, see my issue #34539

[gprosch]

This seems to be a long standing problem, see my issue #34539

Indeed, thank you for the follow-up. Your case helped me get beyond the first issue where I needed to add winmm.lib to the node gyp generated project to build libnode.dll (The node.gyp file appears to be correct at first glance so I am not sure what is wrong.). This enabled me to build the x64 configuration but to build the x86 configuration I had to comment out a line of code in fixed-array.h (line 127):

//DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map());

I am now working on integrating libnode.dll into my application and have numerous unresolved external symbols that I am working through. Wish me luck since this doesn't seem to be an actively supported aspect of nodejs.

[gprosch]

I have been able to build libnode.dll with the aforementioned hacks and have now integrated it into my application and am doing some proof-of-concept development. My gratitude to those who provided assistance. I am leaving the issue open because the issues I had to hack around represent bugs that should be addressed.

[smilovich]

I can manage to create node.dll shared library only for NodeJs 10.24.0 version. For NodeJS 12.21.0 and 14.16.0 it failed to build or in a result didn't generated node.dll file even with fixes from there #34539
I used the following command to build node as a shared library:
.\vcbuild release vs2019 dll x64

[sg2707]

Getting this issue in version 16.10.0

[Developer-Alexander]

error LNK2019: unresolved external symbol __imp__timeGetTime@0

This worked for me: #34539 (comment)

[bnoordhuis]

Fairly sure this has since been fixed so I'll go ahead and close this.