node server crash & reco'd open bug fix

[bpgallagher]

Version

14.16.1

Platform

Microsoft Windows NT 10.0.19044.0 x64

Subsystem

No response

What steps will reproduce the bug?

At first, multiple sessions open. Then simply nodemon app.js with only 1 session.

How often does it reproduce? Is there a required condition?

If multiple sessions are open or if left idle and then return to reuse.

What is the expected behavior?

It's a simple app with 4 pages, but has a cluster of servers plus a replicated database.

What do you see instead?

Perhaps the reason is the compatibility of express modules being used such as cookie-session in place of express-session wrapped with socket.io plus mongo-adapter.

Additional information

No response

[mscdex]

What is the stack trace? Are you sure the crash is not coming from one of the third party modules you're using?

[bpgallagher]

internal/assert.js:14
    throw new ERR_INTERNAL_ASSERTION(message);
    ^

Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
Please open an issue with this stack trace at https://github.com/nodejs/node/issues

    at assert (internal/assert.js:14:11)
    at ServerResponse.detachSocket (_http_server.js:230:3)
    at resOnFinish (_http_server.js:778:7)
    at ServerResponse.emit (events.js:315:20)
    at onFinish (_http_outgoing.js:766:10)
    at callback (internal/streams/writable.js:513:21)
    at afterWrite (internal/streams/writable.js:466:5)
    at afterWriteTick (internal/streams/writable.js:453:10)
    at processTicksAndRejections (internal/process/task_queues.js:79:21) {
  code: 'ERR_INTERNAL_ASSERTION'
}
[nodemon] app crashed - waiting for file changes before starting...

[mscdex]

Based on previous reports with similar stack traces, I'm willing to bet it's something in your code triggering this (directly or indirectly) and not an actual bug in node core.

If you can come up with example code that reproduces this without using third party modules, please post it.

[guillaumeboussion]

If I may help some people with the case I had, my problem was with NestJS, when using @UseInterceptors(ClassSerializerInterceptor) but applied on the whole controller, when some functions were returning classic res.json(...). Removing it and only setting decorators on functions that needed it solved the problem