https proxy reattaches listeners without removing them

[ChALkeR]

This seems minor, but it can trigger MaxListenersExceededWarning on proxy connections

https://github.com/nodejs/node/blob/HEAD/lib/https.js#L224

This can be observed with this change on the proxy side to trigger:

--- a/test/common/proxy-server.js
+++ b/test/common/proxy-server.js
@@ -82,7 +82,11 @@ function createProxyServer(options = {}) {
 
     const normalizedHostname = hostname.startsWith('[') && hostname.endsWith(']') ?
       hostname.slice(1, -1) : hostname;
-    const proxyReq = net.connect(port, normalizedHostname, () => {
+    const proxyReq = net.connect(port, normalizedHostname, async () => {
+      const first = 'HTTP/1.1 200 Connection Established'
+      const slow = 5
+      for (let i = 0; i < slow; i++) {
+        res.write(first[i])
+        await new Promise(a => setTimeout(a, 1))
+      }
       res.write(
-        'HTTP/1.1 200 Connection Established\r\n' +
+        first.slice(slow) + '\r\n' +
         'Proxy-agent: Node.js-Proxy\r\n' +

Results in

(node:68634) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 readable listeners added to [Socket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
    at genericNodeError (node:internal/errors:998:15)
    at wrappedFn (node:internal/errors:543:14)
    at _addListener (node:events:590:17)
    at Socket.addListener (node:events:608:10)
    at Readable.on (node:internal/streams/readable:1136:35)
    at Socket.read (node:https:224:12)
    at Socket.emit (node:events:521:24)
    at emitReadable_ (node:internal/streams/readable:837:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:89:21)

[thisalihassan]

Hi @ChALkeR , opened #62913 for this. tldr the read() function was re-subscribing itself as the 'readable' listener and since EventEmitter snapshots listeners per emit, the count grew exponentially on every chunk (1, 2, 4, 8, 16...) cleanup() also only removed one copy