(v8.x) src: update NODE_MODULE_VERSION to 57 #12995

targos · 2017-05-12T13:10:18Z

Node.js 8.0.0 is API/ABI forward-compatible with V8 6.0.
The current module version is 55 and corresponds to V8 5.8. This
increments the number by two to prevent incompatibility with modules
compiled from Node master.

/cc @nodejs/v8 @jasnell @MylesBorins

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

gibfahn · 2017-05-12T17:26:36Z

Is the NODE_MODULE_VERSION relation to node version documented anywhere?

ofrobots

LGTM given that #12875 has already landed.

addaleax · 2017-05-15T11:48:32Z

@gibfahn I don’t think so. We’re more or less just doing it this way because Electron does releases with most (all?) major V8 versions, I think before that we only increased it for major Node releases (and only by 1).

targos · 2017-05-15T12:17:24Z

Yes, it is to stay aligned with Electron. Ref: electron/electron#5851 (comment)

targos · 2017-05-15T12:18:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/8081/

joshgav · 2017-05-15T16:21:38Z

Should we consider snapping NODE_MODULE_VERSION to the V8/Chromium version? I think this was the case for a while, perhaps by accident. What I specifically mean is should we use 58 for V8 5.8, 60 for V8 6.0 etc.

My main reason for this proposal is to make NODE_MODULE_VERSION easier to reason about.

westy92 · 2017-05-15T19:43:46Z

@joshgav I thought of the same thing, but what would we do for a theoretical V8 6.10?

joshgav · 2017-05-15T19:59:01Z

@westy92

a theoretical V8 6.10?

From what I can tell (e.g. from omahaproxy) V8 and Chromium don't use semver and simply bump by 1 (Chromium) or 0.1 (V8) for each version. For example that's why there's been no consideration of 5.10.

ofrobots · 2017-05-16T00:38:52Z

Should we consider snapping NODE_MODULE_VERSION to the V8/Chromium version? I think this was the case for a while, perhaps by accident. What I specifically mean is should we use 58 for V8 5.8, 60 for V8 6.0 etc.

I have a few thoughts on this: As far as I am aware, the way the Chrome and V8 versions match up (58 ~ 5.8) has been coincidental, and may not stay the same way in the future. Also, more importantly, once N-API moves out of experimental and becomes the official Node module API, the module version would no longer be dependent on V8 and would be dependent on N-API instead. I am not sure if it worth lining up with the chrome version at this point.

addaleax · 2017-05-26T16:14:03Z

Also, more importantly, once N-API moves out of experimental and becomes the official Node module API, the module version would no longer be dependent on V8 and would be dependent on N-API instead.

I don’t think proxying the full V8 API is actually a goal of N-API, so it’s likely that addons using the V8 API will continue to exist?

jasongin · 2017-05-26T16:23:11Z

I don’t think proxying the full V8 API is actually a goal of N-API, so it’s likely that addons using the V8 API will continue to exist?

Absolutely. There will continue to be at least some addons using the V8 API for the foreseeable future, either because they need to do something unusually V8-specific, or because they don't want to take on the cost of migrating their codebase to N-API.

joshgav · 2017-05-26T18:00:49Z

@ofrobots

I am not sure if it worth lining up with the chrome version at this point.

Let's leave out Chrome then, sorry for the red herring 😄 .

@ofrobots what are your thoughts on NODE_MODULE_VERSION as V8 version * 10?

Are there differences which NODE_MODULE_VERSION indicates other than V8 API changes? Have we talked with Electron to understand what leads them to bump the version?

mhdawson · 2017-05-26T20:53:05Z

I think this needs a rebase right ?

mhdawson

LGTM the change itself.

ofrobots · 2017-05-26T23:14:06Z

Absolutely. There will continue to be at least some addons using the V8 API for the foreseeable future, either because they need to do something unusually V8-specific, or because they don't want to take on the cost of migrating their codebase to N-API.

Makes sense. So we have a different way of matching N-API native modules against N-API versions in a given release of Node?

@ofrobots what are your thoughts on NODE_MODULE_VERSION as V8 version * 10?

This is not work in cases such if V8 was to follow a version sequence of the form 5.9 -> 5.10 -> 5.11 -> 6.0.

If y'all think it is beneficial to skip version 57 in order to 'match up' with V8 versions for as long as the current versioning pattern continues... that's fine by me. This will require co-ordination with Electron as they bump the module version for each Chrome (i.e. V8) stable release, and will need to skip 57 as well.

targos · 2017-05-28T08:32:17Z

I will rebase tomorrow.
Are we OK with this version for now? It has to land before the release, so I propose that we postpone the discussion about making the number match V8's version.

jasnell · 2017-05-28T21:34:54Z

@targos ... this will definitely need a rebase now. I had to force push to drop a commit. This needs to land by midday on Monday... I could give it a rebase here shortly if it would help

Node.js 8.0.0 is API/ABI forward-compatible with V8 6.0. The current module version is 55 and corresponds to V8 5.8. This increments the number by two to prevent incompatibility with modules compiled from Node master.

targos · 2017-05-28T21:52:39Z

@jasnell rebased

jasnell · 2017-05-28T21:57:37Z

Will get this landed

Node.js 8.0.0 is API/ABI forward-compatible with V8 6.0. The current module version is 55 and corresponds to V8 5.8. This increments the number by two to prevent incompatibility with modules compiled from Node master. PR-URL: #12995 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell · 2017-05-28T21:59:01Z

Landed in ec7cbaf!

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](nodejs@4a7233c178)] [nodejs#12892](nodejs#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](nodejs@d2d32ea5a2)] [nodejs#11968](nodejs#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](nodejs@7eb1b4658e)] [nodejs#12141](nodejs#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](nodejs@beca3244e2)] [nodejs#10236](nodejs#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](nodejs@97a77288ce)] [nodejs#12348](nodejs#12348), [[`d75fdd96aa`](nodejs@d75fdd96aa)] [nodejs#10423](nodejs#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](nodejs@627ecee9ed)] [nodejs#10653](nodejs#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](nodejs@f18e08d820)] [nodejs#9744](nodejs#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](nodejs@3c3b36af0f)] [nodejs#12936](nodejs#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](nodejs@60d1aac8d2)] [nodejs#12784](nodejs#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](nodejs@84dabe8373)] [nodejs#12489](nodejs#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](nodejs@7a55e34ef4)] [nodejs#10467](nodejs#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](nodejs@3c2a9361ff)] [nodejs#9683](nodejs#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](nodejs@90403dd1d0)] [nodejs#11567](nodejs#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](nodejs@d3480776c7)] [nodejs#11259](nodejs#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](nodejs@fb71ba4921)] [nodejs#11355](nodejs#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](nodejs@3e6f1032a4)] [nodejs#10805](nodejs#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](nodejs@5de3cf099c)] [nodejs#10116](nodejs#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](nodejs@84a23391f6)] [nodejs#12113](nodejs#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](nodejs@56e881d0b0)] [nodejs#11975](nodejs#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](nodejs@03e89b3ff2)] [nodejs#10116](nodejs#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](nodejs@dd20e68b0f)] [nodejs#12725](nodejs#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](nodejs@3f27f02da0)] [nodejs#11599](nodejs#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (nodejs@ec7cbaf266)] [nodejs#12995](nodejs#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](nodejs@a16b570f8c)] [nodejs#11968](nodejs#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](nodejs@010f864426)] [nodejs#12949](nodejs#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](nodejs@a5f91ab230)] [nodejs#11689](nodejs#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](nodejs@8a7db9d4b5)] [nodejs#12087](nodejs#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](nodejs@b6e1d22fa6)] [nodejs#12925](nodejs#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](nodejs@07c7f198db)] [nodejs#12828](nodejs#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](nodejs@348cc80a3c)] [nodejs#5923](nodejs#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](nodejs@a2ae08999b)] [nodejs#11349](nodejs#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](nodejs@d523eb9c40)] [nodejs#11447](nodejs#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](nodejs@d080ead0f9)] [nodejs#12710](nodejs#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](nodejs@5bfd13b81e)] [nodejs#9726](nodejs#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](nodejs@455e6f1dd8)] [nodejs#11708](nodejs#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](nodejs@aab0d202f8)] [nodejs#11624](nodejs#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](nodejs@99da8e8e02)] [nodejs#12442](nodejs#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](nodejs@91383e47fd)] [nodejs#12001](nodejs#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](nodejs@b514bd231e)] [nodejs#11391](nodejs#11391).

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](4a7233c178)] [#12892](#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](d2d32ea5a2)] [#11968](#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](7eb1b4658e)] [#12141](#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](beca3244e2)] [#10236](#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](97a77288ce)] [#12348](#12348), [[`d75fdd96aa`](d75fdd96aa)] [#10423](#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](627ecee9ed)] [#10653](#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](f18e08d820)] [#9744](#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](3c3b36af0f)] [#12936](#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](60d1aac8d2)] [#12784](#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](84dabe8373)] [#12489](#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](7a55e34ef4)] [#10467](#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](3c2a9361ff)] [#9683](#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](90403dd1d0)] [#11567](#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](d3480776c7)] [#11259](#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](fb71ba4921)] [#11355](#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](3e6f1032a4)] [#10805](#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](5de3cf099c)] [#10116](#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](84a23391f6)] [#12113](#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](56e881d0b0)] [#11975](#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](03e89b3ff2)] [#10116](#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](dd20e68b0f)] [#12725](#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](3f27f02da0)] [#11599](#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (ec7cbaf266)] [#12995](#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](a16b570f8c)] [#11968](#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](010f864426)] [#12949](#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](a5f91ab230)] [#11689](#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](8a7db9d4b5)] [#12087](#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](b6e1d22fa6)] [#12925](#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](07c7f198db)] [#12828](#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](348cc80a3c)] [#5923](#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](a2ae08999b)] [#11349](#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](d523eb9c40)] [#11447](#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](d080ead0f9)] [#12710](#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](5bfd13b81e)] [#9726](#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](455e6f1dd8)] [#11708](#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](aab0d202f8)] [#11624](#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](99da8e8e02)] [#12442](#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](91383e47fd)] [#12001](#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](b514bd231e)] [#11391](#11391).

nodejs-github-bot added the v8.x label May 12, 2017

targos changed the title ~~src: update NODE_MODULE_VERSION to 57~~ (v8.x) src: update NODE_MODULE_VERSION to 57 May 12, 2017

ofrobots approved these changes May 12, 2017

View reviewed changes

addaleax approved these changes May 15, 2017

View reviewed changes

gibfahn approved these changes May 15, 2017

View reviewed changes

jasnell approved these changes May 15, 2017

View reviewed changes

jasnell added this to the 8.0.0 milestone May 15, 2017

jasnell force-pushed the v8.x-staging branch 3 times, most recently from 0da62ca to 808d056 Compare May 23, 2017 18:40

mhdawson approved these changes May 26, 2017

View reviewed changes

jasnell force-pushed the v8.x-staging branch from c76231e to 0be029e Compare May 28, 2017 14:40

src: update NODE_MODULE_VERSION to 57

5ded8eb

Node.js 8.0.0 is API/ABI forward-compatible with V8 6.0. The current module version is 55 and corresponds to V8 5.8. This increments the number by two to prevent incompatibility with modules compiled from Node master.

targos force-pushed the v8.x-nmv branch from c8b6a0d to 5ded8eb Compare May 28, 2017 21:52

jasnell closed this May 28, 2017

targos deleted the v8.x-nmv branch May 28, 2017 22:31

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added dont-land-on-v4.x labels Jul 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(v8.x) src: update NODE_MODULE_VERSION to 57 #12995

(v8.x) src: update NODE_MODULE_VERSION to 57 #12995

targos commented May 12, 2017

gibfahn commented May 12, 2017

ofrobots left a comment

addaleax commented May 15, 2017

targos commented May 15, 2017

targos commented May 15, 2017

joshgav commented May 15, 2017

westy92 commented May 15, 2017

joshgav commented May 15, 2017

ofrobots commented May 16, 2017

addaleax commented May 26, 2017

jasongin commented May 26, 2017

joshgav commented May 26, 2017

mhdawson commented May 26, 2017

mhdawson left a comment

ofrobots commented May 26, 2017 •

edited

Loading

targos commented May 28, 2017

jasnell commented May 28, 2017

targos commented May 28, 2017

jasnell commented May 28, 2017

jasnell commented May 28, 2017

(v8.x) src: update NODE_MODULE_VERSION to 57 #12995

(v8.x) src: update NODE_MODULE_VERSION to 57 #12995

Conversation

targos commented May 12, 2017

Checklist

gibfahn commented May 12, 2017

ofrobots left a comment

Choose a reason for hiding this comment

addaleax commented May 15, 2017

targos commented May 15, 2017

targos commented May 15, 2017

joshgav commented May 15, 2017

westy92 commented May 15, 2017

joshgav commented May 15, 2017

ofrobots commented May 16, 2017

addaleax commented May 26, 2017

jasongin commented May 26, 2017

joshgav commented May 26, 2017

mhdawson commented May 26, 2017

mhdawson left a comment

Choose a reason for hiding this comment

ofrobots commented May 26, 2017 • edited Loading

targos commented May 28, 2017

jasnell commented May 28, 2017

targos commented May 28, 2017

jasnell commented May 28, 2017

jasnell commented May 28, 2017

ofrobots commented May 26, 2017 •

edited

Loading