Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
child_process: support Uint8Array input to methods #10653
Affected core subsystem(s)
Its unfortunate we can't do this more globally, so that any API that accepts Buffer also accepts Uint8Array.
Looking at the code change, it looks like making Buffer.isBuffer(x) return
Are we really going to have to change all the APIs one-by-one, such as the TLS APIs that accept Buffer values?
In the short-term, I guess whether APIs support Uint8Array and Buffer will just randomly depend on the module?
I assume there is no better way to do this, but I wanted to call out the inconsistency we are going to have in the short term.