Skip to content

Conversation

@kohei-takata
Copy link
Contributor

No description provided.

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Apr 3, 2015
@rvagg
Copy link
Member

rvagg commented Apr 3, 2015

@tako-black your authorship will show up as:

tako-black <[redacted]>

is this intentional or shall we get a real name in there?

@kohei-takata
Copy link
Contributor Author

@rvagg I'm sorry. I can not understand what you want to say.
My name is Kohei Takata.
I've shown wrong E-mail address what is not for public.
So I want your message delete.
I change my account's E-mail address now.

@bnoordhuis
Copy link
Member

I've redacted the email address in @rvagg's comment but @tako-black, it's still visible here: https://github.com/iojs/io.js/pull/1333.patch (that's what Rod meant by authorship.)

You should probably run git config --global user.email (and amend this PR) if you don't want it to show up in commits.

@rvagg
Copy link
Member

rvagg commented Apr 3, 2015

@tako-black if you don't want your email address in the public then you shouldn't be contributing to open source, particularly via git, because it's all public and that's the new reality. Whatever you make your user.email and user.name will go in to https://github.com/iojs/io.js/blob/v1.x/AUTHORS, so amend your commit accordingly.

@kohei-takata
Copy link
Contributor Author

I amend PR and reopen, so I close this PR.

@bnoordhuis Thank you for your redacting email address in @rvagg's comment, and explaining.
@rvagg I want to change my email address. I can not tell what I want to say. I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants