Replacing for instead of foreach GHC23#49796
Closed
Hannahjef wants to merge 2 commits intonodejs:mainfrom
Closed
Conversation
Hannahjef
commented
Sep 22, 2023
Hannahjef
commented
Yes
nodejs-github-bot
added
needs-ci
tniessen
added
the
code-and-learn
lpinca
reviewed
Nov 2, 2023
lpinca
approved these changes
Nov 2, 2023
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Nov 11, 2023
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49796 ✔ Done loading data for nodejs/node/pull/49796 ----------------------------------- PR info ------------------------------------ Title Replacing for instead of foreach GHC23 (#49796) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Hannahjef:main -> nodejs:main Labels test, code-and-learn, needs-ci Commits 2 - Replacing for instead of foreach GHC23 - Update test/parallel/test-tls-ecdh-multiple.js Committers 2 - Hannahjef <105321681+Hannahjef@users.noreply.github.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/49796 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49796 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 22 Sep 2023 22:59:43 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49796#pullrequestreview-1709626731 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49796#pullrequestreview-1726082969 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-11-02T07:56:32Z: https://ci.nodejs.org/job/node-test-pull-request/55413/ - Querying data for job/node-test-pull-request/55413/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6835327454 |
RafaelGSS
requested changes
Nov 24, 2023
Member
|
Hi! It's been a few months since changes were requested on this PR. @Hannahjef, if you'd still like to pursue this, please make the requested changes, or a team member can open a new-PR with the requested changes. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.