Skip to content

stream: always prefer reading first buffer#51500

Open
ronag wants to merge 1 commit intonodejs:mainfrom
nxtedition:read-buffer
Open

stream: always prefer reading first buffer#51500
ronag wants to merge 1 commit intonodejs:mainfrom
nxtedition:read-buffer

Conversation

@ronag
Copy link
Member

@ronag ronag commented Jan 17, 2024

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2024

Review requested:

  • @nodejs/streams

@ronag ronag requested a review from mcollina January 17, 2024 17:15
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 17, 2024
@ronag
Copy link
Member Author

ronag commented Jan 17, 2024

The old behavior doesn't make much sense to me... This is more efficient.

@mcollina
Copy link
Member

Can you add a test?

How much this is more efficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants