-
-
Notifications
You must be signed in to change notification settings - Fork 34k
doc: remove Corepack documentation page #57663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57663 +/- ##
==========================================
- Coverage 88.58% 88.56% -0.03%
==========================================
Files 704 704
Lines 207774 207774
Branches 40028 40034 +6
==========================================
- Hits 184065 184023 -42
- Misses 15752 15799 +47
+ Partials 7957 7952 -5 🚀 New features to boost your workflow:
|
trivikr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corepack is available in 24.x, and removal of documentation page will create confusion among its existing users. And they may not try experimental features of Node.js again.
The documentation page already links to npm package. We can update it to mention about upcoming removal in v25+ and remove the documentation in v25+.
|
@trivikr you can add the |
This comment was marked as outdated.
This comment was marked as outdated.
That's debatable, we've never shipped any documentation for npm, having one for Corepack is arguably what's inconsistent. |
I added
That's true. There are links to corepack documentation in the wild which point to the latest version of the doc in Node.js. And whoever lands on that page should get to know how they can continue using corepack. A 404 page will lead to loss of trust in any experimental features which Node.js introduces (current and future). |
Would that be a bad thing? IMO users should not trust experimental features. |
It's the trust wrt communication, and it can apply to stable features too. Explaining it with an example makes it clear:
When v24 releases on 2025-04-22 with 404 for corepack documentation
The action after losing trust can be any of the following:
|
That's not going to happen though, this PR has the
dont-land-on-v24.x
|
|
I liked this suggestion from @MikeMcC399 after my vote though
This will help folks landing on corepack documentation from links shared in the ecosystem.
I think v27+ would be a good midway choice, but v26+ is also okay. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I created an alternative PR at #57813 |
|
I've opened nodejs/nodejs.org#7643 to address #57663 (comment) |
|
As per discussion between @aduh95 and me on OpenJS Slack channel |
ee8e115 to
890f739
Compare
PR-URL: nodejs#57663 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
890f739 to
f7ca0ae
Compare
|
Landed in f7ca0ae |
Following up on #57635, let's remove the page. Adding dont-land labels as a cautionary step to avoid 404 in case there are links in the wild to that page. Landing it on 24.x should be fine as long as it lands before 24.0.0.