doc: add missing CAA type to dns.resolveAny() & dnsPromises.resolveAny() #58899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AnyTraits::Parse() method in cares_wrap.cc will "Parse CAA records" as the code comment suggests. The tables in doc should indicate this as well.
|
Review requested:
|
nodejs-github-bot
added
dns
pimterry
approved these changes
Jun 30, 2025
Ethan-Arrowood
approved these changes
Jun 30, 2025
lpinca
approved these changes
Jun 30, 2025
|
It has been some months since the PR is opened. I can see there are a few people clicking approved already. Would maintainers like to take a further look to see if the PR can be merged? |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 520d827 |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2025
The AnyTraits::Parse() method in cares_wrap.cc will "Parse CAA records" as the code comment suggests. The tables in doc should indicate this as well. PR-URL: #58899 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AnyTraits::Parse() method in cares_wrap.cc will "Parse CAA records"
as the code comment suggests. The tables in doc should indicate this as
well.