Skip to content

vm: support compile options#59599

Open
theanarkh wants to merge 1 commit intonodejs:mainfrom
theanarkh:support_eager_compile_in_vm_script
Open

vm: support compile options#59599
theanarkh wants to merge 1 commit intonodejs:mainfrom
theanarkh:support_eager_compile_in_vm_script

Conversation

@theanarkh
Copy link
Contributor

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Aug 23, 2025
@theanarkh theanarkh force-pushed the support_eager_compile_in_vm_script branch 2 times, most recently from daf64a7 to cdbd585 Compare August 23, 2025 17:56
@theanarkh theanarkh force-pushed the support_eager_compile_in_vm_script branch from cdbd585 to 0bdcc76 Compare August 23, 2025 18:07
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.83%. Comparing base (bdcab71) to head (0bdcc76).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
src/node_contextify.cc 84.21% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59599      +/-   ##
==========================================
- Coverage   89.86%   89.83%   -0.03%     
==========================================
  Files         664      667       +3     
  Lines      194944   196094    +1150     
  Branches    38285    38509     +224     
==========================================
+ Hits       175180   176162     +982     
- Misses      12229    12389     +160     
- Partials     7535     7543       +8     
Files with missing lines Coverage Δ
lib/internal/vm.js 100.00% <100.00%> (ø)
lib/vm.js 99.30% <100.00%> (+0.02%) ⬆️
src/node_contextify.cc 81.38% <84.21%> (+0.08%) ⬆️

... and 57 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants