deps: update simdjson to 4.0.7 #59883
Merged
+22,960
−2,101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
|
Review requested:
|
nodejs-github-bot
force-pushed
the
actions/tools-update-simdjson
branch
from
b311b5c to
73ddddb
Compare
nodejs-github-bot
changed the title
|
i think we need to add no-exceptions to test matrix of simdjson |
|
@anonrig We do test without exceptions in various configurations, but, evidently, not sufficiently. A patch is upcoming. |
|
Version 4.0.6 should solve this build errors. See simdjson/simdjson#2464 |
|
Patch 4.0.6 should fix this issue. We were not compiling with The flag is fine by itself, and it should probably be on by default, but it is not, you have to specifically invoke it. But I think it is off by default because it has false positives. In our case, it was a false positive: there were no ambiguities. |
RafaelGSS
previously approved these changes
Sep 21, 2025
|
I meant to approve a different PR, ignore my approval here. |
nodejs-github-bot
changed the title
nodejs-github-bot
force-pushed
the
actions/tools-update-simdjson
branch
from
73ddddb to
2ba6765
Compare
anonrig
approved these changes
Sep 28, 2025
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
nodejs-github-bot
changed the title
nodejs-github-bot
force-pushed
the
actions/tools-update-simdjson
branch
2 times, most recently
from
24e004d to
98ef251
Compare
nodejs-github-bot
force-pushed
the
actions/tools-update-simdjson
branch
2 times, most recently
from
4b563c1 to
b01105b
Compare
aduh95
force-pushed
the
actions/tools-update-simdjson
branch
from
b01105b to
2467f44
Compare
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eea19fa |
aduh95
pushed a commit
that referenced
this pull request
Oct 27, 2025
PR-URL: #59883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of simdjson to 4.0.7.