Conversation
|
Review requested:
|
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60116 +/- ##
==========================================
- Coverage 88.45% 88.44% -0.02%
==========================================
Files 703 704 +1
Lines 207796 207947 +151
Branches 40021 40046 +25
==========================================
+ Hits 183806 183912 +106
- Misses 15977 16021 +44
- Partials 8013 8014 +1
π New features to boost your workflow:
|
|
|
mcollina
left a comment
There was a problem hiding this comment.
Good work!
This has three problems:
- it can loose messages in certain exit circumstances (the system for adding this is already present, see #53239).
- it provides an odd dx where the messages are handled differently between development and production systems.
- util.format is faster than before but still problematic
Iβm not convinced this is a good addition to Node.js, and we should focus on actually adding the log system #49296.
I agree and that was my suggestion actually π |
AugustinMauroy
left a comment
There was a problem hiding this comment.
util.log has been used so if we introduce as it it's will be a massive breaking change
https://nodejs.org/docs/latest/api/deprecations.html#DEP0059
|
I'll close this PR and contribute to #49296 instead. thanks for the reviews! |
hello everyone, last week we disscused this issues : #190,#60032, later we think related nodejs/performance this issue, and @RafaelGSS suggestion after I try create new util.log method for memory friendly log
this new log method : async buffering + batch writes provides