util: improve styleText performance

[BridgeAR]

The validation for when to colorize or not was happening in a loop. Instead, it is now done once up front instead.

[marco-ippolito]

I think the side effect is that the input is no longer validated when colorize is disabled

[BridgeAR]

@marco-ippolito yes, that is correct. It is the question if we need to validate the colors if they are not used.

[marco-ippolito]

@marco-ippolito yes, that is correct. It is the question if we need to validate the colors if they are not used.

I lean more on the yes we should always validate the input (that's why when I previously worked on this api I left the check in the loop) but I really dont have a strong opinion, just wanted to highlight this change

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (7c85aa5) to head (929c3c3).
⚠️ Report is 621 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60133      +/-   ##
==========================================
+ Coverage   88.52%   88.53%   +0.01%     
==========================================
  Files         703      703              
  Lines      207825   207807      -18     
  Branches    40003    40008       +5     
==========================================
+ Hits       183976   183992      +16     
+ Misses      15862    15815      -47     
- Partials     7987     8000      +13     

Files with missing lines	Coverage Δ
lib/util.js	97.96% <100.00%> (-0.01%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69639/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69656/

[marco-ippolito]

I'm still not convinced the performance improvement is worth making this api behave differently depending on the environment.
"if we’re not colorizing, we don’t care about validating color inputs" is not a global assumption.
This might cause unexpected behavior between test environment and production environment for example

[BridgeAR]

@marco-ippolito is that a hard blocker? I think this is an improvement, since a lot of environments will not use colors while they will very likely check during implementation that things work as expected with colors.

[marco-ippolito]

Not a hard blocker, maybe we should document it?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70752/

[marco-ippolito]

I discussed with @BridgeAR at jsconf jp about this PR. Blocking to make sure it doesnt land without resolving my points