Skip to content

doc: deprecations add more codemods #60243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 27, 2025
Merged

doc: deprecations add more codemods #60243

merged 6 commits into from
Oct 27, 2025
+141 −3

Conversation

@AugustinMauroy
Copy link
Member

  • adding more codemods
  • fixing wrong link

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 13, 2025
@AugustinMauroy
Copy link
Member Author

cc @nodejs/userland-migrations

cjihrig
cjihrig approved these changes Oct 13, 2025
View reviewed changes
@brunocroh
Copy link
Member

brunocroh commented Oct 13, 2025 •
edited
Loading

The source code url and run commands for deprecation DEP0028 are incorrect. Could you please include the fix for that one in this PR as well?

- npx codemod@latest @nodejs/util-debug-to-console-error
+ npx codemod@latest @nodejs/util-print-to-console-log
- https://github.com/nodejs/userland-migrations/tree/main/recipes/util-debug-to-console-error 
+ https://github.com/nodejs/userland-migrations/tree/main/recipes/util-print-to-console-log

@AugustinMauroy @brunocroh
Update deprecations.md
9803469 
Co-Authored-By: Bruno Rodrigues <swe@brunocroh.com>
@AugustinMauroy
Copy link
Member Author

good catch @brunocroh

@JakobJingleheimer
Copy link
Member

Let's land this and open subsequent ones rather than keep this going forever 😅

@AugustinMauroy
Copy link
Member Author

Let's land this and open subsequent ones rather than keep this going forever 😅

HAHAHAH yeah maybe

@bjohansebas
Copy link
Member

Is it ready to merge?

@bjohansebas bjohansebas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2025
@aduh95 aduh95 merged commit b9de5d0 into nodejs:main Oct 27, 2025
19 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Oct 27, 2025

Landed in b9de5d0

aduh95 pushed a commit that referenced this pull request Oct 27, 2025
@AugustinMauroy @aduh95
doc: mention more codemods in deprecations.md
425a187 
PR-URL: #60243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

+2 more reviewers

@brunocroh brunocroh brunocroh approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@AugustinMauroy @brunocroh @JakobJingleheimer @bjohansebas @aduh95 @lpinca @cjihrig @nodejs-github-bot