src: use cached primordials_string #60255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Oct 14, 2025
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Oct 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60255 +/- ##
========================================
Coverage 88.57% 88.58%
========================================
Files 704 704
Lines 208183 208324 +141
Branches 40015 40039 +24
========================================
+ Hits 184404 184534 +130
- Misses 15808 15809 +1
- Partials 7971 7981 +10
🚀 New features to boost your workflow:
|
lpinca
approved these changes
Oct 14, 2025
anonrig
reviewed
Oct 14, 2025
src/api/environment.cc
Outdated
| Local<Object> exports; | ||
|
|
||
| if (!GetPerContextExports(context).ToLocal(&exports)) { | ||
| if (!GetPerContextExports(context, isolate_data).ToLocal(&exports)) { |
There was a problem hiding this comment.
This seems to be unrelated to the commit/pull-request title.
There was a problem hiding this comment.
Hi! Thanks for pointing that out. I backed out the unrelated part and kept only the cached primordials. Updated the PR.
anonrig
approved these changes
Oct 14, 2025
KimSH39
force-pushed
the
primordials-cached
branch
from
aafd498 to
8f7e297
Compare
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src: use cached primordials_string ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/18570933910 |
daeyeon
approved these changes
Oct 18, 2025
daeyeon
added
request-ci
github-actions
bot
removed
the
request-ci
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4b8603f |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2025
PR-URL: #60255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cached
primordialsstring from IsolateData and pass isolate_data to GetPerContextExports() to avoid unnecessary string creation and keep the bootstrap path consistent.No functional change.