-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
test: make test-worker-prof more tolerant #60272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems after the recent V8 upgrade, it's no longer safe to assume there'll be 15 ticks per 1500ms. Lower it to 10 ticks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60272 +/- ##
==========================================
- Coverage 88.57% 88.56% -0.02%
==========================================
Files 704 704
Lines 208323 208323
Branches 40037 40037
==========================================
- Hits 184531 184492 -39
- Misses 15811 15856 +45
+ Partials 7981 7975 -6 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that it's already with the V8 update that the time was increased from 1000ms.
I don't understand this test enough to judge whether the numbers of ticks are still testing what we want.
ALREADY REPORTED |
I think as long as the number is not 0, it's "working", though may be working terribly bad if it doesn't have enough sticks for users to understand the profile, but that's not really an issue for Node.js to fix, and flaking the Node.js CI with V8 profiling inefficacy doesn't really help anyone.. cc @addaleax |
Landed in 8429d9a |
It seems after the recent V8 upgrade, it's no longer safe to assume there'll be 15 ticks per 1500ms. Lower it to 10 ticks.
This failed 19 PRs out of the last 100 CI runs in the latest reliability report.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md