just fixed the test shared libraries typo in heading #60321
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
cjihrig
approved these changes
Oct 19, 2025
|
@cjihrig how can i merge this pr? |
|
Fast-track has been requested by @cjihrig. Please 👍 to approve. |
|
@Ronitsabhaya75 the GHA CI needs to run and at least one more approver is needed (otherwise it would need to wait a week to land, but I don't foresee that happening). |
marco-ippolito
approved these changes
Oct 19, 2025
|
@cjihrig i think we got 2 approvers |
|
Note, the CI is currently failing because the commit message does not adhere to the project's standards. |
Changed 'librairies' to 'libraries' in the workflow name.
|
@cjihrig @marco-ippolito I fixed the commit message issue |
cjihrig
approved these changes
Oct 19, 2025
|
@cjihrig can we merge this? |
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6a0c9c8 |
aduh95
added
dont-land-on-v20.x
aduh95
pushed a commit
that referenced
this pull request
Oct 26, 2025
Changed 'librairies' to 'libraries' in the workflow name. PR-URL: #60321 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the typo nothing else was wrong here