-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
tools: add workflow to add author ready
#60554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this recognize "open comment threads"? I personally usually use "comment" instead of "request for changes", so that the review won't be incorrectly interpreted as aggressiveness.
Though the collaborator guide does not require the author to address all the open comments, an automated process to add author ready label may incorrectly give contributor an impression that they can ignore the open comments and the PR is ready to land.
|
Oh, actually the guide does mention the PR should address outstanding review comments before marking it as |
|
It might make sense to change the definition of Anyway, I don't mind adding more heuristics to decrease the chance of mislabelling, if you have more suggestions bring them on! |
|
FWIW, https://github.com/nodejs/node/pulls?q=is:pr+is:open+-label:%22author+ready%22+-label:commit-queue+-label:needs-ci+review:approved+ shows there are about 40 PRs that are likely mergeable; https://github.com/nodejs/node/pulls?q=is:pr+is:open+-label:%22author+ready%22+-label:commit-queue+label:needs-ci+review:approved+ lists 85 that would likely need a CI run before being merged. It's probably too much work for any individual, though if the triaging was done on a more frequent basis, it would be much easier, and my hope is that
author ready
|
The number of PRs keeps creeping up, one of the reason is that we have PRs that have been approved and just forgotten about. By having the
author readyadded automatically, it can help with that as I for one will often check out https://github.com/nodejs/node/pulls?q=is:pr+is:open+label:%22author+ready%22+-label:commit-queue e.g. when preparing a release.Not that this won't add the label to all PRs that deserve it, won't remove it automatically, and might add to some that do not deserve it, so there will still be triagging work to do.