Skip to content

Conversation

@bjohansebas
Copy link
Member

So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Nov 9, 2025
@bjohansebas
Copy link
Member Author

cc: @nodejs/tsc since it’s an end-of-life deprecation

@bjohansebas bjohansebas added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (60b9aaa) to head (007a825).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60658      +/-   ##
==========================================
- Coverage   88.54%   88.52%   -0.03%     
==========================================
  Files         703      701       -2     
  Lines      208077   208054      -23     
  Branches    40082    40084       +2     
==========================================
- Hits       184252   184189      -63     
- Misses      15848    15897      +49     
+ Partials     7977     7968       -9     
Files with missing lines Coverage Δ
lib/internal/main/mksnapshot.js 95.83% <ø> (-0.04%) ⬇️
src/node_builtins.cc 79.32% <ø> (-0.25%) ⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants