Skip to content

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Nov 10, 2025

Summary

  • In test/addons/cppgc-object/test.js, force each gcUntil() loop to request a major GC
    ({ type: 'major', execution: 'beforeUserJS' }). This increases the likelihood that old
    CppGCed wrappers are collected promptly.

  • The test logic remains the same; it just invokes a stronger GC flavor to avoid the CI
    flake where “All old CppGCed are destroyed” never becomes true within 10 attempts.

  • https://github.com/nodejs/node/actions/runs/19245913659/job/55019892774?pr=60665

    Testing

    • make build-addons
    • python3 tools/test.py addons/cppgc-object/test

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (4f1ab8c) to head (e0cd646).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60672      +/-   ##
==========================================
+ Coverage   88.03%   88.55%   +0.52%     
==========================================
  Files         703      703              
  Lines      208257   208257              
  Branches    40069    40156      +87     
==========================================
+ Hits       183336   184420    +1084     
+ Misses      16883    15866    -1017     
+ Partials     8038     7971      -67     

see 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
@nodejs-github-bot
Copy link
Collaborator

@Han5991
Copy link
Contributor Author

Han5991 commented Nov 18, 2025

@legendecas

Hi, this CI failure looks unrelated to the changes in this PR and seems to be caused by a flaky test.
Could you re-run only the failed CI jobs when you get a chance?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants