-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
test: prefer major GC in cppgc-object #60672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Han5991
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
Han5991:fix-cppgc-gc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60672 +/- ##
==========================================
+ Coverage 88.03% 88.55% +0.52%
==========================================
Files 703 703
Lines 208257 208257
Branches 40069 40156 +87
==========================================
+ Hits 183336 184420 +1084
+ Misses 16883 15866 -1017
+ Partials 8038 7971 -67 🚀 New features to boost your workflow:
|
legendecas
reviewed
Nov 11, 2025
24f8a74 to
e0cd646
Compare
joyeecheung
approved these changes
Nov 18, 2025
Collaborator
Contributor
Author
|
Hi, this CI failure looks unrelated to the changes in this PR and seems to be caused by a flaky test. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
test/addons/cppgc-object/test.js, force eachgcUntil()loop to request a major GC(
{ type: 'major', execution: 'beforeUserJS' }). This increases the likelihood that oldCppGCed wrappers are collected promptly.
The test logic remains the same; it just invokes a stronger GC flavor to avoid the CI
flake where “All old CppGCed are destroyed” never becomes true within 10 attempts.
https://github.com/nodejs/node/actions/runs/19245913659/job/55019892774?pr=60665
Testing