-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
[v20.x] tools: drop deprecated macos-13 runner
#60679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
|
Looking at https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories, |
9b50768 to
8f5bc7f
Compare
|
@aduh95 I have dropped "x64" from the commit message. |
8f5bc7f to
d2491b5
Compare
macos-13 runner
|
https://github.com/nodejs/node/actions/runs/19281650811/job/55202686611?pr=60679 We skipped this test in #60419 but the PR references macOS 15.7+ while the GitHub workflow for Node.js 20 is running on macOS 14.8.1. @nodejs/releasers Do you think we should just cherry-pick the commit from #60419, or would the commit message be too misleading and we do an explicit backport? |
|
I think it's fine to cherry-pick, the commit message is still technically correct: after all the commit does skip a test that fails on macOS 15.7+. |
d2491b5 to
269c220
Compare
SGTM. I've cherry-picked the commit to |
Refs: actions/runner-images#13046 PR-URL: #60679 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
|
Landed in 6443ad2 |
Refs: actions/runner-images#13046
cc @nodejs/releasers
Prompted by https://redirect.github.com/nodejs/node/pull/60676.