Skip to content

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Nov 11, 2025

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Nov 11, 2025
@aduh95
Copy link
Contributor

aduh95 commented Nov 11, 2025

Looking at https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories, macos-14 is not x64, the commit message is a bit misleading

@richardlau richardlau changed the title [v20.x] tools: update x64 macOS runner [v20.x] tools: update macOS runner Nov 11, 2025
@richardlau
Copy link
Member Author

richardlau commented Nov 11, 2025

@aduh95 I have dropped "x64" from the commit message.

@richardlau richardlau changed the title [v20.x] tools: update macOS runner [v20.x] tools: drop deprecated macos-13 runner Nov 11, 2025
@richardlau
Copy link
Member Author

richardlau commented Nov 12, 2025

https://github.com/nodejs/node/actions/runs/19281650811/job/55202686611?pr=60679

=== release test-cluster-dgram-1 ===
Path: parallel/test-cluster-dgram-1
Error: Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-cluster-dgram-1.js
--- TIMEOUT ---

===
=== 1 tests failed
===

Failed tests:
out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-cluster-dgram-1.js
make[1]: *** [test-ci] Error 1

We skipped this test in #60419 but the PR references macOS 15.7+ while the GitHub workflow for Node.js 20 is running on macOS 14.8.1.

@nodejs/releasers Do you think we should just cherry-pick the commit from #60419, or would the commit message be too misleading and we do an explicit backport?

@aduh95
Copy link
Contributor

aduh95 commented Nov 12, 2025

I think it's fine to cherry-pick, the commit message is still technically correct: after all the commit does skip a test that fails on macOS 15.7+.

@richardlau
Copy link
Member Author

I think it's fine to cherry-pick, the commit message is still technically correct: after all the commit does skip a test that fails on macOS 15.7+.

SGTM. I've cherry-picked the commit to v20.x-staging and rebased this PR to pick it up.

marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
Refs: actions/runner-images#13046
PR-URL: #60679
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@marco-ippolito
Copy link
Member

Landed in 6443ad2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants