Skip to content

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Nov 13, 2025

Checked in temporal_rs and build it as a static library with ./configure --v8-enable-temporal-support. The dependencies of temporal_rs are locked with Cargo.lock. Temporal is enabled at runtime with cli flag --harmony-temporal.

This does not use V8's default temporal_rs checkout from https://chromium.googlesource.com/chromium/src/third_party/rust/ as it contains all the crates that chromium uses, but V8 may not use them.

For follow-ups, the temporal_capi needs to respect Node's ICU and toolchain settings. Additionally, we may want to force cargo to work in offline mode.

Refs: #58730
Refs: #60693

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 13, 2025

Review requested:

  • @nodejs/security-wg
  • @nodejs/build

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Nov 13, 2025
@marco-ippolito
Copy link
Member

I dont know if its a good idea,
might be a terrible idea, I'm not a rust expert, but I know technically we could vendor the rust dependencies with https://doc.rust-lang.org/cargo/commands/cargo-vendor.html
so we keep dont have to download them from the internet?

@richardlau
Copy link
Member

Yeah, I think ultimately (not necessarily to start with if it is opt-in but definitely before it becomes enabled by default) we need a way to be able to build temporal offline (e.g. from the Node.js source tarball).

@legendecas
Copy link
Member Author

I agree. It's in the roadmap as the OP mentioned.

@legendecas legendecas added the v8 engine Issues and PRs related to the V8 dependency. label Nov 13, 2025
@legendecas
Copy link
Member Author

Blocked on #60701 to get the v8.gyp change landed first.

@legendecas legendecas added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. tools Issues and PRs related to the tools directory. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. blocked PRs that are blocked by other issues or PRs. labels Nov 13, 2025
@legendecas legendecas force-pushed the temporal branch 2 times, most recently from 53f8347 to 5b1ac50 Compare November 13, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants