-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
deps: add support of temporal_rs #60703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
|
I dont know if its a good idea, |
|
Yeah, I think ultimately (not necessarily to start with if it is opt-in but definitely before it becomes enabled by default) we need a way to be able to build temporal offline (e.g. from the Node.js source tarball). |
|
I agree. It's in the roadmap as the OP mentioned. |
|
Blocked on #60701 to get the v8.gyp change landed first. |
53f8347 to
5b1ac50
Compare
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
Checked in
temporal_rsand build it as a static library with./configure --v8-enable-temporal-support. The dependencies oftemporal_rsare locked withCargo.lock. Temporal is enabled at runtime with cli flag--harmony-temporal.This does not use V8's default temporal_rs checkout from https://chromium.googlesource.com/chromium/src/third_party/rust/ as it contains all the crates that chromium uses, but V8 may not use them.
For follow-ups, the
temporal_capineeds to respect Node's ICU and toolchain settings. Additionally, we may want to force cargo to work in offline mode.Refs: #58730
Refs: #60693