build: add flag to compile V8 with Temporal support #60701
+63
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B.: it only works if you provide the
temporal_capia shared library.I've tested it with:
nix-shell --arg withTemporal true --run 'make build-ci -j12'nix-shell --arg icu null --arg withTemporal true --run 'make build-ci -j12'nix-shell --argstr icu small --arg withTemporal true --run 'make build-ci -j12'I needed to apply the following patch, IIUC that's related to targeting a different version of
temporal_capi(already fixed upstream v8/v8@0cbecc1 and v8/v8@e0dc7e8), and V8 using some non-exposed ICU internals.The first commit is cherry-picked from #60693, cc @targos
Refs: #58730