build: fix OpenSSL version parsing for OpenSSL < 3 #60775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL versions before 3.0.0 do not define - `OPENSSL_VERSION_MAJOR` - `OPENSSL_VERSION_MINOR` - `OPENSSL_VERSION_PATCH` in `openssl/opensslv.h`. For these versions, `OPENSSL_VERSION_NUMBER` is a literal which we can parse directly.
richardlau
added
dont-land-on-v20.x
nodejs-github-bot
added
build
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Nov 18, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
aduh95
approved these changes
Nov 18, 2025
aduh95
added
the
author ready
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 0771137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL versions before 3.0.0 do not define
OPENSSL_VERSION_MAJOROPENSSL_VERSION_MINOROPENSSL_VERSION_PATCHin
openssl/opensslv.h. For these versions,OPENSSL_VERSION_NUMBERis a literal which we can parse directly.Noticed this in, e.g. https://ci.nodejs.org/job/node-test-commit-linux-containered/53610/nodes=ubuntu2404_sharedlibs_openssl111_x64/consoleFull
it should instead be
(
269488511=0x1010117F)FWIW I'm planning a follow up a PR after this to warn for OpenSSL versions < 3. I've kept the changes separate as this PR should land on v25.x but the warning for OpenSSL < 3 would be semver-major.