-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
test_runner: simplify code and make it more consistent #60777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60777 +/- ##
==========================================
+ Coverage 88.04% 88.54% +0.49%
==========================================
Files 703 703
Lines 208260 208249 -11
Branches 40068 40157 +89
==========================================
+ Hits 183360 184389 +1029
+ Misses 16840 15882 -958
+ Partials 8060 7978 -82
🚀 New features to boost your workflow:
|
Hardanish-Singh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pmarchini
approved these changes
Nov 19, 2025
meixg
approved these changes
Nov 19, 2025
Collaborator
IlyasShabi
approved these changes
Nov 19, 2025
Collaborator
Collaborator
|
Landed in 5e6ac7e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reuse the
setOwnPropertyhelper; also I realized thatdeferred.resolveis sometimes used directly as a callback, or sometimes wrapped in an arrow function.