Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 18, 2025

We can reuse the setOwnProperty helper; also I realized that deferred.resolve is sometimes used directly as a callback, or sometimes wrapped in an arrow function.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (0b6ae6d) to head (f4a66d2).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60777      +/-   ##
==========================================
+ Coverage   88.04%   88.54%   +0.49%     
==========================================
  Files         703      703              
  Lines      208260   208249      -11     
  Branches    40068    40157      +89     
==========================================
+ Hits       183360   184389    +1029     
+ Misses      16840    15882     -958     
+ Partials     8060     7978      -82     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.34% <100.00%> (-0.02%) ⬇️

... and 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Hardanish-Singh Hardanish-Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5e6ac7e into nodejs:main Nov 20, 2025
80 of 84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5e6ac7e

@aduh95 aduh95 deleted the test-runner-consistent branch November 20, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants