-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
test: fix debug test crashes caused by sea tests #60807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmoroz
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
vmoroz:pr/fix_sea_test_debug_crash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60807 +/- ##
==========================================
+ Coverage 88.43% 88.56% +0.12%
==========================================
Files 703 703
Lines 208235 208254 +19
Branches 40085 40176 +91
==========================================
+ Hits 184162 184430 +268
+ Misses 16069 15841 -228
+ Partials 8004 7983 -21 🚀 New features to boost your workflow:
|
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/19639758969 |
StefanStojanovic
approved these changes
Nov 25, 2025
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we compile for debug on Windows we have the tests crashing with the error log shown below.
The root cause of the issue is that when the SEA tests are probing for parallel execution they call
context.GetVm('none', 'none').This call results with trying to use
Release\node.exethat is not created for debug-only builds.In this PR we record the first
--modepassed totools\test.pyand then we use it as a fallback when thecontext.GetVm('none', 'none')raises an exception.Since I do not know the full background why we use none/none and why
GetVmunconditionally returns the Release path in that case, this is the best solution that I could come with. Feel free to propose a better version.This PR and and PR #60806 finally unblock the test runs on Windows while working on the code.
The error log being addressed by this PR: