tools: enforce trailing commas in test/es-module
#60891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60891 +/- ##
==========================================
+ Coverage 88.51% 88.53% +0.01%
==========================================
Files 703 703
Lines 208406 208406
Branches 40193 40215 +22
==========================================
+ Hits 184468 184504 +36
+ Misses 15938 15928 -10
+ Partials 8000 7974 -26 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Nov 29, 2025
aduh95
added
author ready
legendecas
approved these changes
Dec 3, 2025
PR-URL: nodejs#60891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
force-pushed
the
comma-dangle-esm
branch
from
6c22420 to
9877403
Compare
Contributor
Author
|
Landed in 9877403 |
targos
pushed a commit
that referenced
this pull request
Dec 5, 2025
PR-URL: #60891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only a handful missing, seems like a good time to enable it.