Skip to content

src: remove unused private field in SQLTagStore #61027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 20, 2025
Merged

src: remove unused private field in SQLTagStore #61027

nodejs-github-bot merged 1 commit into from
Dec 20, 2025

Conversation

@targos
Copy link
Member

@targos targos commented Dec 12, 2025

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 12, 2025

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (14f02fc) to head (df23a6c).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61027      +/-   ##
==========================================
+ Coverage   88.52%   88.53%   +0.01%     
==========================================
  Files         703      703              
  Lines      208538   208537       -1     
  Branches    40214    40228      +14     
==========================================
+ Hits       184615   184635      +20     
+ Misses      15921    15913       -8     
+ Partials     8002     7989      -13
Files with missing lines Coverage Δ
src/node_sqlite.cc 79.91% <100.00%> (-0.01%) ⬇️
src/node_sqlite.h 80.39% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 12, 2025
gurgunday
gurgunday approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70525/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 9a6e55a into nodejs:main Dec 20, 2025
83 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2025

Landed in 9a6e55a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos @nodejs-github-bot @lpinca @cjihrig @tniessen @Renegade334 @gurgunday