Skip to content

test_runner: replace native methods with primordials#61219

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Ayoub-Mabrouk:test_runner-use-primordials-snapshot
Feb 24, 2026
Merged

test_runner: replace native methods with primordials#61219
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Ayoub-Mabrouk:test_runner-use-primordials-snapshot

Conversation

@Ayoub-Mabrouk
Copy link
Contributor

Replace native methods with primordials.

Replace native methods with primordials.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (5c8ce91) to head (de2a8de).
⚠️ Report is 403 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61219      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.01%     
==========================================
  Files         703      703              
  Lines      208613   208614       +1     
  Branches    40252    40246       -6     
==========================================
+ Hits       184684   184714      +30     
+ Misses      15951    15912      -39     
- Partials     7978     7988      +10     
Files with missing lines Coverage Δ
lib/internal/test_runner/snapshot.js 98.09% <100.00%> (+<0.01%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2026
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@JakobJingleheimer JakobJingleheimer added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2026
@JakobJingleheimer
Copy link
Member

I can't figure out why CI is unhappy (Jenkins claims the page is not found), so I added author-ready to signal this is seemingly g2g.

@Ayoub-Mabrouk
Copy link
Contributor Author

I can't figure out why CI is unhappy (Jenkins claims the page is not found), so I added author-ready to signal this is seemingly g2g.

Thank you 🙏

@JakobJingleheimer JakobJingleheimer added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2026
@JakobJingleheimer
Copy link
Member

Ah, the CI job is too old (older than 21 days), so it needs to be re-run. Triggered it now (I'll keep an eye on it).

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2026
@nodejs-github-bot
Copy link
Collaborator

@JakobJingleheimer JakobJingleheimer added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 24, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2026
@nodejs-github-bot nodejs-github-bot merged commit 14aaf4e into nodejs:main Feb 24, 2026
88 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 14aaf4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants