Skip to content

lib: fix source map url parse in dynamic imports#61990

Open
legendecas wants to merge 1 commit intonodejs:mainfrom
legendecas:invalid-source-map-url
Open

lib: fix source map url parse in dynamic imports#61990
legendecas wants to merge 1 commit intonodejs:mainfrom
legendecas:invalid-source-map-url

Conversation

@legendecas
Copy link
Member

Fixes #61988

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 25, 2026
@legendecas legendecas added lib / src Issues and PRs related to general changes in the lib or src directory. source maps Issues and PRs related to source map support. labels Feb 25, 2026
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Renegade334
Copy link
Member

Salient failure?

@legendecas
Copy link
Member Author

I think the coverage npx c8 report didn't use the node built in the workflow. Also the error is from c8. Maybe I can tweek the test to make c8 happy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. source maps Issues and PRs related to source map support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sourcemap Support Breaks Data URL Dynamic Imports

5 participants