doc: fix module.stripTypeScriptTypes indentation#61992
Merged
Renegade334 merged 1 commit intonodejs:mainfrom Feb 28, 2026
Merged
doc: fix module.stripTypeScriptTypes indentation#61992Renegade334 merged 1 commit intonodejs:mainfrom
Renegade334 merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
Renegade334
added
strip-types
legendecas
approved these changes
Feb 25, 2026
JakobJingleheimer
approved these changes
Feb 25, 2026
Renegade334
added
author ready
marco-ippolito
approved these changes
Feb 26, 2026
HarshithaKP
approved these changes
Feb 26, 2026
cjihrig
approved these changes
Feb 26, 2026
lpinca
approved these changes
Feb 26, 2026
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61992 ✔ Done loading data for nodejs/node/pull/61992 ----------------------------------- PR info ------------------------------------ Title doc: fix module.stripTypeScriptTypes indentation (#61992) Author René <contact.9a5d6388@renegade334.me.uk> (@Renegade334) Branch Renegade334:doc-module-stst-indentation -> nodejs:main Labels doc, author ready, dont-land-on-v20.x, strip-types Commits 1 - doc: fix module.stripTypeScriptTypes indentation Committers 1 - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/61992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 25 Feb 2026 21:30:38 GMT ✔ Approvals: 6 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61992#pullrequestreview-3857136748 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/61992#pullrequestreview-3857150972 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/61992#pullrequestreview-3859375857 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/61992#pullrequestreview-3860465407 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61992#pullrequestreview-3860790185 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61992#pullrequestreview-3863737607 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/22504895963 |
marco-ippolito
approved these changes
Feb 28, 2026
Member
|
Can you rebase instead of merging |
PR-URL: nodejs#61992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Renegade334
force-pushed
the
doc-module-stst-indentation
branch
from
a27b79f to
6964b53
Compare
Member
Author
|
Landed in 6964b53 |
Renegade334
removed
the
commit-queue-failed
richardlau
pushed a commit
that referenced
this pull request
Mar 2, 2026
PR-URL: #61992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method description got squished into the returns field.