doc: fix small logic error in DETECT_MODULE_SYNTAX#62025
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 1, 2026
Merged
doc: fix small logic error in DETECT_MODULE_SYNTAX#62025nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
JakobJingleheimer
approved these changes
Feb 27, 2026
marco-ippolito
approved these changes
Feb 27, 2026
Renegade334
added
author ready
Lxxyx
approved these changes
Feb 27, 2026
cjihrig
approved these changes
Feb 28, 2026
lpinca
approved these changes
Feb 28, 2026
RaisinTen
approved these changes
Mar 1, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 0994958 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super pedantic, but the case where a source parses as ESM but doesn't contain any ESM-only syntax currently falls off the end of the algorithm without a resolution.