Skip to content

crypto: add support for Ed25519 context parameter#62474

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
panva:ed25519ctx-sign-verify
Mar 31, 2026
Merged

crypto: add support for Ed25519 context parameter#62474
nodejs-github-bot merged 1 commit intonodejs:mainfrom
panva:ed25519ctx-sign-verify

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Mar 28, 2026

Extracted from #62345

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 28, 2026
@panva panva force-pushed the ed25519ctx-sign-verify branch from 8921f51 to a73d32d Compare March 28, 2026 10:29
@panva panva marked this pull request as ready for review March 28, 2026 10:30
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva force-pushed the ed25519ctx-sign-verify branch from a73d32d to dd20526 Compare March 28, 2026 10:33
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (cf2b05c) to head (dd20526).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62474   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files         691      691           
  Lines      213943   213943           
  Branches    41039    41039           
=======================================
+ Hits       191909   191920   +11     
- Misses      14089    14090    +1     
+ Partials     7945     7933   -12     
Files with missing lines Coverage Δ
src/crypto/crypto_sig.cc 71.51% <ø> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2026
@nodejs-github-bot nodejs-github-bot merged commit 9df9b66 into nodejs:main Mar 31, 2026
70 of 72 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 9df9b66

@panva panva deleted the ed25519ctx-sign-verify branch March 31, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants