quic: add QuicEndpoint.listening & QuicStream.destroy() and tests#62648
Open
pimterry wants to merge 1 commit intonodejs:mainfrom
Open
quic: add QuicEndpoint.listening & QuicStream.destroy() and tests#62648pimterry wants to merge 1 commit intonodejs:mainfrom
pimterry wants to merge 1 commit intonodejs:mainfrom
Conversation
Starting to explore and cover the existing implementation, this covers the basic endpoint & stream lifecycle and the exposed properties. Added endpoint.listening to match net.Server and round out endpoint properties, and stream.destroy() which is already called by quicSession.destroy() and documented, but didn't actually exist. Signed-off-by: Tim Perry <pimterry@gmail.com>
nodejs-github-bot
added
needs-ci
avivkeller
approved these changes
Apr 9, 2026
jasnell
approved these changes
Apr 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62648 +/- ##
==========================================
- Coverage 89.80% 89.79% -0.02%
==========================================
Files 699 699
Lines 216154 216174 +20
Branches 41317 41316 -1
==========================================
- Hits 194122 194115 -7
- Misses 14130 14175 +45
+ Partials 7902 7884 -18
🚀 New features to boost your workflow:
|
jasnell
added
the
author ready
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to explore and cover the existing implementation. This covers the basic endpoint & stream lifecycle and the exposed properties.
Added
endpoint.listeningto match net.Server.listening and round of the set of properties, andstream.destroy()which is already called byquicSession.destroy()and documented, but didn't actually exist - without this, the test fails atclientSession.destroy().Getting started on the easy bits here, I'm planning to slowly build up tests to cover the list in #60122 and patch any issues as I go.
(This currently doesn't build due to the unrelated #62595 issue, but there's no relationship, it works if you just comment the ngtcp2 test server/client build out).