lib,permission: add permission.drop#62672
Conversation
|
Review requested:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #62672 +/- ##
==========================================
- Coverage 89.64% 89.64% -0.01%
==========================================
Files 708 708
Lines 220399 220562 +163
Branches 42267 42303 +36
==========================================
+ Hits 197577 197718 +141
- Misses 14667 14700 +33
+ Partials 8155 8144 -11
🚀 New features to boost your workflow:
|
|
As mentioned in my comments on the linked issue, I feel like it should be explicitly documented that this only drops permissions and does not close currently open file handles, sockets etc, that it is expected behaviour and is the app code's responsibility to close/release those if they are no longer required. |
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
f36bd66 to
995de8e
Compare
Refs: #62223