build: fix stray debug string in LIEF defines#62683
Open
om-ghante wants to merge 1 commit intonodejs:mainfrom
Open
build: fix stray debug string in LIEF defines#62683om-ghante wants to merge 1 commit intonodejs:mainfrom
om-ghante wants to merge 1 commit intonodejs:mainfrom
Conversation
A stray debug string 'testtttt' in lief.gyp's defines list was missing a trailing comma, causing it to be concatenated with the adjacent MBEDTLS_CONFIG_FILE define via implicit string concatenation. This resulted in the compiler receiving: -DtestttttMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" instead of: -DMBEDTLS_CONFIG_FILE="config/mbedtls/config.h" Remove the stray string so that MBEDTLS_CONFIG_FILE is defined correctly. Refs: nodejs#62129
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stray debug string
'testtttt'in lief.gyp's defines list was missinga trailing comma, causing it to be concatenated with the adjacent
MBEDTLS_CONFIG_FILEdefine via GYP's implicit string concatenation.Current (broken):
-DtestttttMBEDTLS_CONFIG_FILE="config/mbedtls/config.h"Expected (fixed):
-DMBEDTLS_CONFIG_FILE="config/mbedtls/config.h"This means mbedtls was never receiving its intended config file path. Remove
the stray string so
MBEDTLS_CONFIG_FILEis defined correctly.Risk
Fixing this define may change mbedtls behavior if it was previously falling
back to a default config. Reviewers should verify that
config/mbedtls/config.his the correct config path and that LIEF's mbedtlsusage works correctly with it.
Related: PR #62682 addresses the duplicate C++ standard flags in the same file.
Refs: #62129