Skip to content

src: use context-free V8 message column getters#62778

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Renegade334:message-column-getters-nomaybe
Apr 18, 2026
Merged

src: use context-free V8 message column getters#62778
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Renegade334:message-column-getters-nomaybe

Conversation

@Renegade334
Copy link
Copy Markdown
Member

The Message::Get*Column(context) getters return a Maybe<int>, but since v8/v8@9fe417c, the context is no longer necessary and these methods just return Just(Get*Column()). We may as well cut out the overhead.

Refs: https://issues.chromium.org/issues/42210793

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 16, 2026
@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2026
@nodejs-github-bot

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (db9da5d) to head (73b3185).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62778      +/-   ##
==========================================
- Coverage   91.54%   89.69%   -1.86%     
==========================================
  Files         356      706     +350     
  Lines      149604   218143   +68539     
  Branches    23392    41735   +18343     
==========================================
+ Hits       136961   195657   +58696     
- Misses      12380    14422    +2042     
- Partials      263     8064    +7801     
Files with missing lines Coverage Δ
src/inspector_agent.cc 80.52% <100.00%> (ø)
src/node_errors.cc 63.86% <100.00%> (ø)

... and 469 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Renegade334 Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2026
@nodejs-github-bot nodejs-github-bot merged commit ad44dc4 into nodejs:main Apr 18, 2026
84 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in ad44dc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants